]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appMenu: Move setApp to null before destroy
authorJonian Guveli <jonian@hardpixel.eu>
Sun, 31 Dec 2023 18:30:11 +0000 (20:30 +0200)
committerJonian Guveli <jonian@hardpixel.eu>
Sun, 31 Dec 2023 18:30:11 +0000 (20:30 +0200)
Calling `setApp` after the menu has been destroyed results in error.
Moving the method before `super.destroy()` fixes the issue.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2998>

js/ui/appMenu.js

index e3825a81ed69aa18e89f90ff20c4fbc805710966..1569aa6cef9ee7a29cf88f1fbccd34e612d92e4c 100644 (file)
@@ -199,9 +199,8 @@ export class AppMenu extends PopupMenu.PopupMenu {
 
     /** */
     destroy() {
-        super.destroy();
-
         this.setApp(null);
+        super.destroy();
     }
 
     /**